netdev - Re: Re: [PATCH V2] ethernet: stmmac: support driver work for DTs without child queue node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 29 Apr 2022 14:14:56 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     "jay.xu@...k-chips.com" <jay.xu@...k-chips.com>
Cc:     kuba <kuba@...nel.org>, davem <davem@...emloft.net>,
        joabreu <joabreu@...opsys.com>,
        "alexandre.torgue" <alexandre.torgue@...com>,
        "peppe.cavallaro" <peppe.cavallaro@...com>,
        netdev <netdev@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Device Tree <devicetree@...r.kernel.org>
Subject: Re: Re: [PATCH V2] ethernet: stmmac: support driver work for DTs
 without child queue node

Adding device tree list.

This is mostly a device tree issue, so the device tree Maintainers
should be part of the discussion.

> >On Fri, Apr 29, 2022 at 08:46:05AM +0800, Jianqun Xu wrote:
> >> The driver use the value of property 'snps,rx-queues-to-use' to loop
> >> same numbers child nodes as queues, such as:
> >>
> >>     gmac {
> >>         rx-queues-config {
> >>             snps,rx-queues-to-use = <1>;
> >>             queue0 {
> >>                 // nothing need here.
> >>     };
> >> };
> >>     };
> >>
> >> Since a patch for dtc from rockchip will delete all node without any
> >> properties or child node, the queue0 node will be deleted, that caused
> >> the driver fail to probe:
> >
> >Is this the in tree dtc? Do you have a commit hash for it? That should
> >probably be used as a Fixes: tag. Or that change to dtc needs
> >reverting because it breaks stuff.
> > 
> The patch is a hack patch for some products and have not in tree dtc, I said that to
> explain a possible case how things happed, it's only a case of no child queue node.

So this has nothing to do with the kernel dtc, or the upstream
dtc. This is only a 'vendor crap' dtc which has been hacked?

Why should mainline care? Is there anything in the DT standard which
says the compiler can optimise out empty properties?

     Andrew