netdev - Re: [RFC PATCH v11 net-next 06/10] net: dsa: microchip: add support for phylink management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YmwLNz1xeTED7xM/@shell.armlinux.org.uk>
Date:   Fri, 29 Apr 2022 16:58:47 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
Cc:     andrew@...n.ch, netdev@...r.kernel.org, olteanv@...il.com,
        robh+dt@...nel.org, UNGLinuxDriver@...rochip.com,
        woojung.huh@...rochip.com, hkallweit1@...il.com,
        davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        devicetree@...r.kernel.org, pabeni@...hat.com
Subject: Re: [RFC PATCH v11 net-next 06/10] net: dsa: microchip: add support
 for phylink management

On Fri, Mar 25, 2022 at 10:23:37PM +0530, Prasanna Vengateshan wrote:
> +static void lan937x_apply_rgmii_delay(struct ksz_device *dev, int port,
> +				      phy_interface_t interface, u8 val)
> +{
> +	struct ksz_port *p = &dev->ports[port];
> +
> +	/* Clear Ingress & Egress internal delay enabled bits */
> +	val &= ~(PORT_RGMII_ID_EG_ENABLE | PORT_RGMII_ID_IG_ENABLE);
> +
> +	/* if the delay is 0, do not enable DLL */
> +	if (p->rgmii_tx_val) {
> +		lan937x_update_rgmii_tx_rx_delay(dev, port, true);
> +		dev_info(dev->dev, "Applied rgmii tx delay for the port %d\n",
> +			 port);
> +		val |= PORT_RGMII_ID_EG_ENABLE;
> +	}
> +
> +	/* if the delay is 0, do not enable DLL */
> +	if (p->rgmii_rx_val) {
> +		lan937x_update_rgmii_tx_rx_delay(dev, port, false);
> +		dev_info(dev->dev, "Applied rgmii rx delay for the port %d\n",
> +			 port);
> +		val |= PORT_RGMII_ID_IG_ENABLE;
> +	}
> +
> +	/* Enable RGMII internal delays */
> +	lan937x_pwrite8(dev, port, REG_PORT_XMII_CTRL_1, val);

"interface" doesn't appear to be used in this function, do you need to
pass it?

Other than that, the patch looks good, thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!