netdev - Re: [PATCH net-next] net: phy: Deduplicate interrupt disablement on PHY attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 29 Apr 2022 02:10:12 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Lukas Wunner <lukas@...ner.de>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        hkallweit1@...il.com, andrew@...n.ch, linux@...linux.org.uk,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: phy: Deduplicate interrupt disablement on PHY
 attach

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 27 Apr 2022 08:30:51 +0200 you wrote:
> phy_attach_direct() first calls phy_init_hw() (which restores interrupt
> settings through ->config_intr()), then calls phy_disable_interrupts().
> 
> So if phydev->interrupts was previously set to 1, interrupts are briefly
> enabled, then disabled, which seems nonsensical.
> 
> If it was previously set to 0, interrupts are disabled twice, which is
> equally nonsensical.
> 
> [...]

Here is the summary with links:
  - [net-next] net: phy: Deduplicate interrupt disablement on PHY attach
    https://git.kernel.org/netdev/net-next/c/07caad0bb1f8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html