netdev - Re: [PATCH net-next v2 01/15] eth: remove copies of the NAPI_POLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c962f441-05b8-8aa1-5186-c85251f3e0ba@gmail.com>
Date:   Fri, 29 Apr 2022 09:11:54 +0100
From:   "Durrant, Paul" <xadimgnik@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net,
        pabeni@...hat.com
Cc:     edumazet@...gle.com, netdev@...r.kernel.org,
        ulli.kroll@...glemail.com, linus.walleij@...aro.org,
        mlindner@...vell.com, stephen@...workplumber.org, nbd@....name,
        john@...ozen.org, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
        matthias.bgg@...il.com, grygorii.strashko@...com,
        wei.liu@...nel.org, paul@....org,
        prabhakar.mahadev-lad.rj@...renesas.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-omap@...r.kernel.org,
        xen-devel@...ts.xenproject.org
Subject: Re: [PATCH net-next v2 01/15] eth: remove copies of the
 NAPI_POLL_WEIGHT define

On 28/04/2022 22:23, Jakub Kicinski wrote:
> Defining local versions of NAPI_POLL_WEIGHT with the same
> values in the drivers just makes refactoring harder.
> 
> Drop the special defines in a bunch of drivers where the
> removal is relatively simple so grouping into one patch
> does not impact reviewability.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: ulli.kroll@...glemail.com
> CC: linus.walleij@...aro.org
> CC: mlindner@...vell.com
> CC: stephen@...workplumber.org
> CC: nbd@....name
> CC: john@...ozen.org
> CC: sean.wang@...iatek.com
> CC: Mark-MC.Lee@...iatek.com
> CC: matthias.bgg@...il.com
> CC: grygorii.strashko@...com
> CC: wei.liu@...nel.org
> CC: paul@....org
> CC: prabhakar.mahadev-lad.rj@...renesas.com
> CC: linux-arm-kernel@...ts.infradead.org
> CC: linux-mediatek@...ts.infradead.org
> CC: linux-omap@...r.kernel.org
> CC: xen-devel@...ts.xenproject.org
> ---
>   drivers/net/ethernet/cortina/gemini.c         | 4 +---
>   drivers/net/ethernet/marvell/skge.c           | 3 +--
>   drivers/net/ethernet/marvell/sky2.c           | 3 +--
>   drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 +--
>   drivers/net/ethernet/ti/davinci_emac.c        | 3 +--
>   drivers/net/ethernet/ti/netcp_core.c          | 5 ++---
>   drivers/net/xen-netback/interface.c           | 3 +--
>   7 files changed, 8 insertions(+), 16 deletions(-)
> 

xen-netback patch...

Reviewed-by: Paul Durrant <paul@....org>