lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Apr 2022 12:59:04 +0200 From: Johannes Berg <johannes@...solutions.net> To: Srinivasan Raju <srini.raju@...elifi.com> Cc: Kalle Valo <kvalo@...nel.org>, "David S. Miller" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "open list:NETWORKING DRIVERS (WIRELESS)" <linux-wireless@...r.kernel.org>, "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] [v2] plfxlc: fix le16_to_cpu warning for beacon_interval On Fri, 2022-04-29 at 10:44 +0000, Srinivasan Raju wrote: > Fix the following sparse warnings: > > drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval > drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype] > > Reported-by: kernel test robot <lkp@...el.com> > Signed-off-by: Srinivasan Raju <srini.raju@...elifi.com> > --- > drivers/net/wireless/purelifi/plfxlc/chip.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c > index a5ec10b66ed5..79d187cf3715 100644 > --- a/drivers/net/wireless/purelifi/plfxlc/chip.c > +++ b/drivers/net/wireless/purelifi/plfxlc/chip.c > @@ -29,11 +29,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval, > u8 dtim_period, int type) > { > if (!interval || > - (chip->beacon_set && > - le16_to_cpu(chip->beacon_interval) == interval)) > + (chip->beacon_set && chip->beacon_interval) == interval) > I think you got the parentheses wrong. johannes
Powered by blists - more mailing lists