netdev - Re: [PATCH net-next 01/14] eth: remove copies of the NAPI_POLL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYOrUkVCW6Bq2V0wkk+2AEP3tkw18m4ra83Gn29knxhYA@mail.gmail.com>
Date:   Mon, 2 May 2022 00:10:12 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, pabeni@...hat.com, netdev@...r.kernel.org,
        ulli.kroll@...glemail.com, mlindner@...vell.com,
        stephen@...workplumber.org, nbd@....name, john@...ozen.org,
        sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com,
        matthias.bgg@...il.com, grygorii.strashko@...com,
        wei.liu@...nel.org, paul@....org,
        prabhakar.mahadev-lad.rj@...renesas.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-omap@...r.kernel.org,
        xen-devel@...ts.xenproject.org
Subject: Re: [PATCH net-next 01/14] eth: remove copies of the NAPI_POLL_WEIGHT define

On Wed, Apr 27, 2022 at 5:41 PM Jakub Kicinski <kuba@...nel.org> wrote:

> Defining local versions of NAPI_POLL_WEIGHT with the same
> values in the drivers just makes refactoring harder.
>
> Drop the special defines in a bunch of drivers where the
> removal is relatively simple so grouping into one patch
> does not impact reviewability.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: ulli.kroll@...glemail.com
> CC: linus.walleij@...aro.org
> CC: mlindner@...vell.com
> CC: stephen@...workplumber.org
> CC: nbd@....name
> CC: john@...ozen.org
> CC: sean.wang@...iatek.com
> CC: Mark-MC.Lee@...iatek.com
> CC: matthias.bgg@...il.com
> CC: grygorii.strashko@...com
> CC: wei.liu@...nel.org
> CC: paul@....org
> CC: prabhakar.mahadev-lad.rj@...renesas.com
> CC: linux-arm-kernel@...ts.infradead.org
> CC: linux-mediatek@...ts.infradead.org
> CC: linux-omap@...r.kernel.org
> CC: xen-devel@...ts.xenproject.org

Looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij