netdev - Re: [PATCH net] octeontx2-af: debugfs: fix error return of allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220502143101.3aa37dac@kernel.org>
Date:   Mon, 2 May 2022 14:31:01 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Niels Dossche <dossche.niels@...il.com>
Cc:     netdev@...r.kernel.org, Sunil Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        Jerin Jacob <jerinj@...vell.com>,
        hariprasad <hkelam@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Harman Kalra <hkalra@...vell.com>,
        Christina Jacob <cjacob@...vell.com>
Subject: Re: [PATCH net] octeontx2-af: debugfs: fix error return of
 allocations

On Sat, 30 Apr 2022 21:46:56 +0200 Niels Dossche wrote:
> @@ -407,7 +407,7 @@ static ssize_t rvu_dbg_rsrc_attach_status(struct file *filp,
>  
>  	buf = kzalloc(buf_size, GFP_KERNEL);
>  	if (!buf)
> -		return -ENOSPC;
> +		return -ENOMEM;
>  
>  	/* Get the maximum width of a column */
>  	lf_str_size = get_max_column_width(rvu);

Looks intentional, other allocation failures in this file use ENOMEM.
Still probably worth cleaning up, applied to net-next.