netdev - RE: [Intel-wired-lan] [PATCH v5] igb: Convert kmap() to kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB3367A2BBE81A95AAEF6D0498FCC19@BYAPR11MB3367.namprd11.prod.outlook.com>
Date:   Mon, 2 May 2022 09:29:56 +0000
From:   "G, GurucharanX" <gurucharanx.g@...el.com>
To:     "Weiny, Ira" <ira.weiny@...el.com>,
        Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
CC:     "outreachy@...ts.linux.dev" <outreachy@...ts.linux.dev>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v5] igb: Convert kmap() to
 kmap_local_page()



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Ira Weiny
> Sent: Thursday, April 21, 2022 11:19 PM
> To: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
> Cc: outreachy@...ts.linux.dev; intel-wired-lan@...ts.osuosl.org; linux-
> kernel@...r.kernel.org; netdev@...r.kernel.org; kuba@...nel.org;
> pabeni@...hat.com; davem@...emloft.net
> Subject: Re: [Intel-wired-lan] [PATCH v5] igb: Convert kmap() to
> kmap_local_page()
> 
> On Wed, Apr 20, 2022 at 01:43:13AM +0200, Alaa Mohamed wrote:
> > kmap() is being deprecated and these usages are all local to the
> > thread so there is no reason kmap_local_page() can't be used.
> >
> > Replace kmap() calls with kmap_local_page().
> >
> > Signed-off-by: Alaa Mohamed
> <eng.alaamohamedsoliman.am@...il.com>
> 
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> 
> > ---
> > changes in V2:
> > 	fix kunmap_local path value to take address of the mapped page.
> > ---
> > changes in V3:
> > 	edit commit message to be clearer
> > ---
> > changes in V4:
> > 	edit the commit message
> > ---
> > changes in V5:
> > 	-edit commit subject
> > 	-edit commit message
> > ---
> >  drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >

Tested-by: Gurucharan <gurucharanx.g@...el.com> (A Contingent worker at Intel)