netdev - Re: [PATCH net-next v2 1/3] net: phy: broadcom: Add PTP support for some Broadcom PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9b5c49dcd2b62549c8980d8e812715ee54c5d473.camel@redhat.com>
Date:   Mon, 02 May 2022 11:55:13 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, andrew@...n.ch,
        hkallweit1@...il.com, richardcochran@...il.com, lasse@...ebeat.app
Cc:     netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH net-next v2 1/3] net: phy: broadcom: Add PTP support for
 some Broadcom PHYs.

Hello,

On Fri, 2022-04-29 at 19:57 -0700, Jonathan Lemon wrote:
> This adds PTP support for BCM54210E Broadcom PHYs, in particular,
> the BCM54213PE, as used in the Rasperry PI CM4.  It has only been
> tested on that hardware.
> 
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>

Another nit-pick, sorry ;)

This introduces a few compiler warnings for undeclared functions
(bcm_ptp_config_init and bcm_ptp_probe), see:

https://patchwork.hopto.org/static/nipa/637209/12833026/build_allmodconfig_warn/summary

The warnings could be addressed e.g. re-ordering patch 1/3 and 2/3.

Thanks!

Paolo