netdev - Re: [PATCH] net/mlx5: correct ECE offset in query qp output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Ym+/WnWceotzny4f@unreal>
Date:   Mon, 2 May 2022 14:24:10 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Saeed Mahameed <saeedm@...dia.com>
Cc:     Changcheng Liu <changchengx.liu@...look.com>,
        linux-rdma@...r.kernel.org, linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net/mlx5: correct ECE offset in query qp output

On Tue, Apr 26, 2022 at 10:06:11PM +0800, Changcheng Liu wrote:
> 
> From cd2890fc0f756d809f684768fabb34b449df6d29 Mon Sep 17 00:00:00 2001
> From: Changcheng Liu <jerrliu@...dia.com>
> Date: Tue, 26 Apr 2022 21:28:14 +0800
> Subject: [PATCH] net/mlx5: correct ECE offset in query qp output
> 
> ECE field should be after opt_param_mask in query qp output.
> 
> Fixes: 6b646a7e4af6 ("net/mlx5: Add ability to read and write ECE options")
> Signed-off-by: Changcheng Liu <jerrliu@...dia.com>

Saeed,

Do you plan to add new patches to mlx5-next?
This change can go to that branch as this field is not used in current
code at all.

Thanks

> 
> diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
> index 7d2d0ba82144..2e162ec2a3d3 100644
> --- a/include/linux/mlx5/mlx5_ifc.h
> +++ b/include/linux/mlx5/mlx5_ifc.h
> @@ -5180,12 +5180,11 @@ struct mlx5_ifc_query_qp_out_bits {
>  
>  	u8         syndrome[0x20];
>  
> -	u8         reserved_at_40[0x20];
> -	u8         ece[0x20];
> +	u8         reserved_at_40[0x40];
>  
>  	u8         opt_param_mask[0x20];
>  
> -	u8         reserved_at_a0[0x20];
> +	u8         ece[0x20];
>  
>  	struct mlx5_ifc_qpc_bits qpc;
>  
> -- 
> 2.27.0
>