netdev - Re: [PATCH v2] net: sfp: Add tx-fault workaround for Huawei MA5671A SFP ONT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnGqR2fMdk/dglm7@lunn.ch>
Date:   Wed, 4 May 2022 00:18:47 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Matthew Hagan <mnhagan88@...il.com>
Cc:     Russell King <linux@...linux.org.uk>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: sfp: Add tx-fault workaround for Huawei MA5671A
 SFP ONT

On Mon, May 02, 2022 at 11:33:15PM +0100, Matthew Hagan wrote:
> As noted elsewhere, various GPON SFP modules exhibit non-standard
> TX-fault behaviour. In the tested case, the Huawei MA5671A, when used
> in combination with a Marvell mv88e6085 switch, was found to
> persistently assert TX-fault, resulting in the module being disabled.
> 
> This patch adds a quirk to ignore the SFP_F_TX_FAULT state, allowing the
> module to function.
> 
> Change from v1: removal of erroneous return statment (Andrew Lunn)
> 
> Signed-off-by: Matthew Hagan <mnhagan88@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew