netdev - Re: [PATCH net] selftests: ocelot: tc_flower_chains: specify conform-exceed action for policer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnEd9f5KisUvnDzg@shredder>
Date:   Tue, 3 May 2022 15:20:05 +0300
From:   Ido Schimmel <idosch@...dia.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        UNGLinuxDriver@...rochip.com,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        Colin Foster <colin.foster@...advantage.com>
Subject: Re: [PATCH net] selftests: ocelot: tc_flower_chains: specify
 conform-exceed action for policer

On Tue, May 03, 2022 at 03:14:28PM +0300, Vladimir Oltean wrote:
> As discussed here with Ido Schimmel:
> https://patchwork.kernel.org/project/netdevbpf/patch/20220224102908.5255-2-jianbol@nvidia.com/
> 
> the default conform-exceed action is "reclassify", for a reason we don't
> really understand.
> 
> The point is that hardware can't offload that police action, so not
> specifying "conform-exceed" was always wrong, even though the command
> used to work in hardware (but not in software) until the kernel started
> adding validation for it.
> 
> Fix the command used by the selftest by making the policer drop on
> exceed, and pass the packet to the next action (goto) on conform.
> 
> Fixes: 8cd6b020b644 ("selftests: ocelot: add some example VCAP IS1, IS2 and ES0 tc offloads")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Ido Schimmel <idosch@...dia.com>