netdev - Re: [PATCH net-next] net/core: Remove comment quote for __dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220503180341.36dcbb07@kernel.org>
Date:   Tue, 3 May 2022 18:03:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     linux-doc@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au>,
        Dave Jones <davej@...hat.com>,
        Randy Dunlap <randy.dunlap@...cle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Pavel Begunkov <asml.silence@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/core: Remove comment quote for
 __dev_queue_xmit()

On Tue,  3 May 2022 14:29:49 +0700 Bagas Sanjaya wrote:
> - * -----------------------------------------------------------------------------------
> - *      I notice this method can also return errors from the queue disciplines,
> - *      including NET_XMIT_DROP, which is a positive value.  So, errors can also
> - *      be positive.
> - *
> - *      Regardless of the return value, the skb is consumed, so it is currently
> - *      difficult to retry a send to this method.  (You can bump the ref count
> - *      before sending to hold a reference for retry if you are careful.)
> - *
> - *      When calling this method, interrupts MUST be enabled.  This is because
> - *      the BH enable code must have IRQs enabled so that it will not deadlock.
> - *          --BLG
> + *	This method can also return positive errno code from the queue
> + *	disciplines (including NET_XMIT_DROP).
> + *
> + *	Note that regardless of the return value, the skb is consumed
> + *	anyway, so it is currently difficult to retry sending to this
> + *	method.

Why drop almost half of the comment if the problem is just the ----
banner?