netdev - Re: [PATCH mlx5-next 0/5] Improve mlx5 live migration driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4295eaec-9b11-8665-d3b4-b986a65d1d47@nvidia.com>
Date:   Wed, 4 May 2022 16:29:37 +0300
From:   Yishai Hadas <yishaih@...dia.com>
To:     <alex.williamson@...hat.com>, <jgg@...dia.com>, <saeedm@...dia.com>
CC:     <kvm@...r.kernel.org>, <netdev@...r.kernel.org>, <kuba@...nel.org>,
        <leonro@...dia.com>, <maorg@...dia.com>, <cohuck@...hat.com>
Subject: Re: [PATCH mlx5-next 0/5] Improve mlx5 live migration driver

On 27/04/2022 12:31, Yishai Hadas wrote:
> This series improves mlx5 live migration driver in few aspects as of
> below.
>
> Refactor to enable running migration commands in parallel over the PF
> command interface.
>
> To achieve that we exposed from mlx5_core an API to let the VF be
> notified before that the PF command interface goes down/up. (e.g. PF
> reload upon health recovery).
>
> Once having the above functionality in place mlx5 vfio doesn't need any
> more to obtain the global PF lock upon using the command interface but
> can rely on the above mechanism to be in sync with the PF.
>
> This can enable parallel VFs migration over the PF command interface
> from kernel driver point of view.
>
> In addition,
> Moved to use the PF async command mode for the SAVE state command.
> This enables returning earlier to user space upon issuing successfully
> the command and improve latency by let things run in parallel.
>
> Alex, as this series touches mlx5_core we may need to send this in a
> pull request format to VFIO to avoid conflicts before acceptance.
>
> Yishai
>
> Yishai Hadas (5):
>    vfio/mlx5: Reorganize the VF is migratable code
>    net/mlx5: Expose mlx5_sriov_blocking_notifier_register /  unregister
>      APIs
>    vfio/mlx5: Manage the VF attach/detach callback from the PF
>    vfio/mlx5: Refactor to enable VFs migration in parallel
>    vfio/mlx5: Run the SAVE state command in an async mode
>
>   .../net/ethernet/mellanox/mlx5/core/sriov.c   |  65 ++++-
>   drivers/vfio/pci/mlx5/cmd.c                   | 229 +++++++++++++-----
>   drivers/vfio/pci/mlx5/cmd.h                   |  50 +++-
>   drivers/vfio/pci/mlx5/main.c                  | 133 +++++-----
>   include/linux/mlx5/driver.h                   |  12 +
>   5 files changed, 358 insertions(+), 131 deletions(-)
>
Hi Alex,

Did you have the chance to look at the series ? It touches mlx5 code 
(vfio, net), no core changes.

This may go apparently via your tree as a PR from mlx5-next once you'll 
be fine with.

Thanks,
Yishai