netdev - Re: [PATCH] wfx: use container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 May 2022 13:07:26 -0400
From:   Jaehee Park <jhpark1013@...il.com>
To:     Kalle Valo <kvalo@...nel.org>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Stefano Brivio <sbrivio@...hat.com>,
        Jérôme Pouiller <jerome.pouiller@...abs.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        Outreachy Linux Kernel <outreachy@...ts.linux.dev>
Subject: Re: [PATCH] wfx: use container_of() to get vif

On Wed, May 04, 2022 at 07:05:57PM +0300, Kalle Valo wrote:
> Dan Carpenter <dan.carpenter@...cle.com> writes:
> 
> > On Wed, May 04, 2022 at 01:50:59PM +0200, Stefano Brivio wrote:
> >> And that it's *obvious* that container_of() would trigger warnings
> >> otherwise. Well, obvious just for me, it seems.
> >
> > :P
> >
> > Apparently it wasn't obvious to Kalle and me.  My guess is that you saw
> > the build error.  Either that or Kalle and I are geezers who haven't
> > looked at container_of() since before the BUILD_BUG_ON() was added five
> > years ago.
> 
> Exactly, I also had to duplicate the error myself before I was able to
> understand the issue. So I'm officially a geezer now :D
> 

Hi Dan and Kalle, thanks for your messages!
Understood -- I'll copy the error for reference next time. Sorry you
had to recreate the build error yourself!

> -- 
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches