netdev - Re: [PATCH v3 net-next 1/2] net: phy: microchip: update LAN88xx phy ID and phy ID mask.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnLzHfeo6dyULtbs@lunn.ch>
Date:   Wed, 4 May 2022 23:41:49 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Yuiko Oshino <yuiko.oshino@...rochip.com>
Cc:     woojung.huh@...rochip.com, davem@...emloft.net,
        netdev@...r.kernel.org, ravi.hegde@...rochip.com,
        UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v3 net-next 1/2] net: phy: microchip: update LAN88xx phy
 ID and phy ID mask.

On Wed, May 04, 2022 at 08:28:21AM -0700, Yuiko Oshino wrote:
> update LAN88xx phy ID and phy ID mask because the existing code conflicts with the LAN8742 phy.
> 
> The current phy IDs on the available hardware.
>         LAN8742 0x0007C130, 0x0007C131
>         LAN88xx 0x0007C132
> 
> Signed-off-by: Yuiko Oshino <yuiko.oshino@...rochip.com>

>  static struct phy_driver microchip_phy_driver[] = {
>  {
> -	.phy_id		= 0x0007c130,
> -	.phy_id_mask	= 0xfffffff0,
> +	.phy_id		= 0x0007c132,
> +	/* This mask (0xfffffff2) is to differentiate from
> +	 * LAN8742 (phy_id 0x0007c130 and 0x0007c131)
> +	 * and allows future phy_id revisions.
> +	 */
> +	.phy_id_mask	= 0xfffffff2,

It is odd, but you should be able to change your mind later if the
hardware engineers don't actually stick to this odd scheme.

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew