netdev - Re: [PATCH net v2 2/2] net: phy: micrel: Pass .probe for KS8737

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnL1jLQ5A6/RraYm@lunn.ch>
Date:   Wed, 4 May 2022 23:52:12 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Fabio Estevam <festevam@...il.com>
Cc:     kuba@...nel.org, davem@...emloft.net, claudiu.beznea@...rochip.com,
        netdev@...r.kernel.org, o.rempel@...gutronix.de,
        linux@...linux.org.uk, Fabio Estevam <festevam@...x.de>,
        stable@...r.kernel.org
Subject: Re: [PATCH net v2 2/2] net: phy: micrel: Pass .probe for KS8737

On Wed, May 04, 2022 at 11:31:04AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@...x.de>
> 
> Since commit f1131b9c23fb ("net: phy: micrel: use
> kszphy_suspend()/kszphy_resume for irq aware devices") the kszphy_suspend/
> resume hooks are used.
> 
> These functions require the probe function to be called so that
> priv can be allocated.
> 
> Otherwise, a NULL pointer dereference happens inside
> kszphy_config_reset().
> 
> Cc: stable@...r.kernel.org
> Fixes: f1131b9c23fb ("net: phy: micrel: use kszphy_suspend()/kszphy_resume for irq aware devices")
> Reported-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Fabio Estevam <festevam@...x.de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew