netdev - Re: [PATCH net-next v3 2/6] ptp: Request cycles for TX timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 05 May 2022 12:52:55 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Gerhard Engleder <gerhard@...leder-embedded.com>,
        richardcochran@...il.com, vinicius.gomes@...el.com,
        yangbo.lu@....com, davem@...emloft.net, kuba@...nel.org
Cc:     mlichvar@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/6] ptp: Request cycles for TX timestamp

On Sun, 2022-05-01 at 13:18 +0200, Gerhard Engleder wrote:
> The free running cycle counter of physical clocks called cycles shall be
> used for hardware timestamps to enable synchronisation.
> 
> Introduce new flag SKBTX_HW_TSTAMP_USE_CYCLES, which signals driver to
> provide a TX timestamp based on cycles if cycles are supported.
> 
> Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>
> ---
>  include/linux/skbuff.h |  5 +++++
>  net/core/skbuff.c      |  5 +++++
>  net/socket.c           | 11 ++++++++++-
>  3 files changed, 20 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
> index 3270cb72e4d8..fa03e02b761d 100644
> --- a/include/linux/skbuff.h
> +++ b/include/linux/skbuff.h
> @@ -615,6 +615,11 @@ enum {
>  	/* device driver is going to provide hardware time stamp */
>  	SKBTX_IN_PROGRESS = 1 << 2,
>  
> +	/* generate hardware time stamp based on cycles if supported, flag is
> +	 * used only for TX path
> +	 */
> +	SKBTX_HW_TSTAMP_USE_CYCLES = 1 << 3,
> +
>  	/* generate wifi status information (where possible) */
>  	SKBTX_WIFI_STATUS = 1 << 4,

Don't you need to update accordingly SKBTX_ANY_TSTAMP, so that this
flags is preserved on segmentation?


Thanks!

Paolo