netdev - Re: [PATCH net-next v3 4/6] ptp: Support late timestamp determination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220505140213.GC1492@hoboy.vegasvil.org>
Date:   Thu, 5 May 2022 07:02:13 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Gerhard Engleder <gerhard@...leder-embedded.com>
Cc:     vinicius.gomes@...el.com, yangbo.lu@....com, davem@...emloft.net,
        kuba@...nel.org, mlichvar@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 4/6] ptp: Support late timestamp determination

On Sun, May 01, 2022 at 01:18:34PM +0200, Gerhard Engleder wrote:
> @@ -620,6 +625,11 @@ enum {
>  	 */
>  	SKBTX_HW_TSTAMP_USE_CYCLES = 1 << 3,
>  
> +	/* determine hardware time stamp based on time or cycles, flag is used
> +	 * only for RX path
> +	 */
> +	SKBTX_HW_TSTAMP_NETDEV = 1 << 3,

Rather than re-using bit 3, why not just use bit 5?

Then you can:

- remove the magic clearing in patch #2
- protect against future changes that would skip the magic clearing

>  	/* generate wifi status information (where possible) */
>  	SKBTX_WIFI_STATUS = 1 << 4,
>  

Thanks,
Richard