netdev - Re: [PATCH net-next] net: align SO_RCVMARK required privileges with SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 15:51:48 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eyal Birger <eyal.birger@...il.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        asml.silence@...il.com, aahringo@...hat.com, weiwan@...gle.com,
        fw@...len.de, yangbo.lu@....com, tglx@...utronix.de,
        dsahern@...nel.org, lnx.erin@...il.com, mkl@...gutronix.de,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: align SO_RCVMARK required privileges with
 SO_MARK

On Wed,  4 May 2022 12:54:59 +0300 Eyal Birger wrote:
> The commit referenced in the "Fixes" tag added the SO_RCVMARK socket
> option for receiving the skb mark in the ancillary data.
> 
> Since this is a new capability, and exposes admin configured details
> regarding the underlying network setup to sockets, let's align the
> needed capabilities with those of SO_MARK.
> 
> Fixes: 6fd1d51cfa25 ("net: SO_RCVMARK socket option for SO_MARK with recvmsg()")
> Signed-off-by: Eyal Birger <eyal.birger@...il.com>

It's not really as bad as the ability to set the mark, but since 
Erin is not complaining I assume it's fine with their use case.