netdev - Re: [EXT] Re: [PATCH 0/5] net: atlantic: more fuzzing fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 09:11:02 +0200
From:   Igor Russkikh <irusskikh@...vell.com>
To:     Grant Grundler <grundler@...omium.org>,
        Dmitrii Bezrukov <dbezrukov@...vell.com>
CC:     Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        LKML <linux-kernel@...r.kernel.org>,
        Aashay Shringarpure <aashay@...gle.com>,
        "Yi Chou" <yich@...gle.com>,
        Shervin Oloumi <enlightened@...gle.com>
Subject: Re: [EXT] Re: [PATCH 0/5] net: atlantic: more fuzzing fixes


Hi Grant and Dmitrii,

>> So to close session I guess need to set is_rsc_completed to true when 
>> number of frags is going to exceed value MAX_SKB_FRAGS, then packet will 
>> be built and submitted to stack.
>> But of course need to check that there will not be any other corner cases 
>> with this new change.
> 
> Ok. Sounds like I should post a v2 then and just drop 1/5 and 5/5
> patches.  Will post that tomorrow.

I think the part with check `hw_head_ >= ring->size` still can be used safely (patch 5).

For patch 1 - I agree it may make things worse, so either drop or think on how to interpret invalid `next` and stop LRO session.

Thanks,
   Igor