netdev - Re: [PATCH net-next v3 1/3] net: phy: broadcom: Add Broadcom PTP hooks to bcm-phy-lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed3c3eec-a79d-0d8a-09ad-4a2c6c5507eb@gmail.com>
Date:   Fri, 6 May 2022 10:17:29 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jonathan Lemon <jonathan.lemon@...il.com>, f.fainelli@...il.com,
        bcm-kernel-feedback-list@...adcom.com, andrew@...n.ch,
        hkallweit1@...il.com, richardcochran@...il.com, lasse@...ebeat.app
Cc:     netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH net-next v3 1/3] net: phy: broadcom: Add Broadcom PTP
 hooks to bcm-phy-lib

On 5/4/22 15:43, Jonathan Lemon wrote:
> Add the public bcm_ptp_probe() and bcm_ptp_config_init() functions
> to the bcm-phy library.  The PTP functions are contained in a separate
> file for clarity, and also to simplify the PTP clock dependencies.
> 
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>

This could really be squashed into the next patch since you do not 
introduce the ability to build that code until patch #3.

I would also re-order patches #2 and #3 thus making it ultimately a 2 
patch series only.
-- 
Florian