Message-Id: <20220506180052.5256-1-anthony.l.nguyen@intel.com>
Date:   Fri,  6 May 2022 11:00:50 -0700
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>, netdev@...r.kernel.org,
        marcin.szycik@...ux.intel.com
Subject: [PATCH net-next 0/2][pull request] 100GbE Intel Wired LAN Driver Updates 2022-05-06

Marcin Szycik says:

This patchset adds support for systemd defined naming scheme for port
representors, as well as re-enables displaying PCI bus-info in ethtool.

bus-info information has previously been removed from ethtool for port
representors, as a workaround for a bug in lshw tool, where the tool would
sometimes display wrong descriptions for port representors/PF. Now the bug
has been fixed in lshw tool [1].

Removing the workaround can be considered a regression (user might be
running an older, unpatched version of lshw) (see [2] for discussion).
However, calling SET_NETDEV_DEV also produces the same effect as removing
the workaround, i.e. lshw is able to access PCI bus-info (this time not
via ethtool, but in some other way) and the bug can occur.

Adding SET_NETDEV_DEV is important, as it greatly improves netdev naming -
- port representors are named based on PF name. Currently port representors
are named "ethX", which might be confusing, especially when spawning VFs on
multiple PFs. Furthermore, it's currently harder to determine to which PF
does a particular port representor belong, as bus-info is not shown in
ethtool.

Consider the following three cases:


Case 1: current code - driver workaround in place, no SET_NETDEV_DEV,
lshw with or without fix. Port representors are not displayed because they
don't have bus-info (the workaround), PFs are labelled correctly:

$ sudo ./lshw -c net -businfo
Bus info          Device      Class          Description
========================================================
pci@...0:02:00.0  ens6f0      network        Ethernet Controller E810-XXV for SFP <-- PF
pci@...0:02:00.1  ens6f1      network        Ethernet Controller E810-XXV for SFP
pci@...0:02:01.0  ens6f0v0    network        Ethernet Adaptive Virtual Function <-- VF
pci@...0:02:01.1  ens6f0v1    network        Ethernet Adaptive Virtual Function
...


Case 2: driver workaround in place, SET_NETDEV_DEV, no lshw fix. Port
representors have predictable names. lshw is able to get bus-info because
of SET_NETDEV_DEV and netdevs CAN be mislabelled:

$ sudo ./lshw -c net -businfo
Bus info          Device           Class          Description
=============================================================
pci@...0:02:00.0  ens6f0npf0vf60   network        Ethernet Controller E810-XXV for SFP <-- mislabeled port representor
pci@...0:02:00.1  ens6f1           network        Ethernet Controller E810-XXV for SFP
pci@...0:02:01.0  ens6f0v0         network        Ethernet Adaptive Virtual Function
pci@...0:02:01.1  ens6f0v1         network        Ethernet Adaptive Virtual Function
...
pci@...0:02:00.0  ens6f0npf0vf26   network        Ethernet interface
pci@...0:02:00.0  ens6f0           network        Ethernet interface <-- mislabeled PF
pci@...0:02:00.0  ens6f0npf0vf81   network        Ethernet interface
...
$ sudo ethtool -i ens6f0npf0vf60
driver: ice
...
bus-info:
...

Output of lshw would be the same with workaround removed; it does not
change the fact that lshw labels netdevs incorrectly, while at the same
time it prevents ethtool from displaying potentially useful data
(bus-info).


Case 3: workaround removed, SET_NETDEV_DEV, lshw fix:

$ sudo ./lshw -c net -businfo
Bus info          Device           Class          Description
=============================================================
pci@...0:02:00.0  ens6f0npf0vf73   network        Ethernet Controller E810-XXV for SFP
pci@...0:02:00.1  ens6f1           network        Ethernet Controller E810-XXV for SFP
pci@...0:02:01.0  ens6f0v0         network        Ethernet Adaptive Virtual Function
pci@...0:02:01.1  ens6f0v1         network        Ethernet Adaptive Virtual Function
...
pci@...0:02:00.0  ens6f0npf0vf5    network        Ethernet Controller E810-XXV for SFP
pci@...0:02:00.0  ens6f0           network        Ethernet Controller E810-XXV for SFP
pci@...0:02:00.0  ens6f0npf0vf60   network        Ethernet Controller E810-XXV for SFP
...
$ sudo ethtool -i ens6f0npf0vf73
driver: ice
...
bus-info: 0000:02:00.0
...

In this case poort representors have predictable names, netdevs are not
mislabelled in lshw, and bus-info is shown in ethtool.

[1] https://ezix.org/src/pkg/lshw/commit/9bf4e4c9c1
[2] https://patchwork.ozlabs.org/project/intel-wired-lan/patch/20220321144731.3935-1-marcin.szycik@linux.intel.com

The following are changes since commit 95730d65708397828f75ca7dbca838edf6727bfd:
  Merge branch 'tso-gso-limit-split'
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE

Marcin Szycik (1):
  Revert "ice: Hide bus-info in ethtool for PRs in switchdev mode"

Michal Swiatkowski (1):
  ice: link representors to PCI device

 drivers/net/ethernet/intel/ice/ice_ethtool.c | 8 +++-----
 drivers/net/ethernet/intel/ice/ice_repr.c    | 1 +
 2 files changed, 4 insertions(+), 5 deletions(-)

-- 
2.35.1

Powered by blists - more mailing lists