netdev - [net-next:master 9/16] drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:567:23: warning: variable 'flow6' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202205070459.Ht5py3HQ-lkp@intel.com>
Date:   Sat, 7 May 2022 04:48:33 +0800
From:   kernel test robot <lkp@...el.com>
To:     Louis Peens <louis.peens@...igine.com>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        Yinjun Zhang <yinjun.zhang@...igine.com>,
        Simon Horman <simon.horman@...igine.com>
Subject: [net-next:master 9/16]
 drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:567:23: warning:
 variable 'flow6' set but not used

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head:   95730d65708397828f75ca7dbca838edf6727bfd
commit: c83a0fbe9766b3ae970b96435b7c9786299a9b12 [9/16] nfp: flower: remove unused neighbour cache
config: riscv-randconfig-c024-20220506 (https://download.01.org/0day-ci/archive/20220507/202205070459.Ht5py3HQ-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=c83a0fbe9766b3ae970b96435b7c9786299a9b12
        git remote add net-next https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
        git fetch --no-tags net-next master
        git checkout c83a0fbe9766b3ae970b96435b7c9786299a9b12
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/net/ethernet/netronome/nfp/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c: In function 'nfp_tun_neigh_event_handler':
>> drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c:567:23: warning: variable 'flow6' set but not used [-Wunused-but-set-variable]
     567 |         struct flowi6 flow6 = {};
         |                       ^~~~~


vim +/flow6 +567 drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.c

50b1c86ab0a075 John Hurley 2019-12-17  559  
8e6a9046b66a7d John Hurley 2017-09-25  560  static int
8e6a9046b66a7d John Hurley 2017-09-25  561  nfp_tun_neigh_event_handler(struct notifier_block *nb, unsigned long event,
8e6a9046b66a7d John Hurley 2017-09-25  562  			    void *ptr)
8e6a9046b66a7d John Hurley 2017-09-25  563  {
8e6a9046b66a7d John Hurley 2017-09-25  564  	struct nfp_flower_priv *app_priv;
8e6a9046b66a7d John Hurley 2017-09-25  565  	struct netevent_redirect *redir;
6c463a059f626b John Hurley 2019-12-17  566  	struct flowi4 flow4 = {};
6c463a059f626b John Hurley 2019-12-17 @567  	struct flowi6 flow6 = {};
8e6a9046b66a7d John Hurley 2017-09-25  568  	struct neighbour *n;
8e6a9046b66a7d John Hurley 2017-09-25  569  	struct nfp_app *app;
9d5447ed44b5dd Louis Peens 2022-05-05  570  	bool neigh_invalid;
6c463a059f626b John Hurley 2019-12-17  571  	bool ipv6 = false;
8e6a9046b66a7d John Hurley 2017-09-25  572  	int err;
8e6a9046b66a7d John Hurley 2017-09-25  573  
8e6a9046b66a7d John Hurley 2017-09-25  574  	switch (event) {
8e6a9046b66a7d John Hurley 2017-09-25  575  	case NETEVENT_REDIRECT:
8e6a9046b66a7d John Hurley 2017-09-25  576  		redir = (struct netevent_redirect *)ptr;
8e6a9046b66a7d John Hurley 2017-09-25  577  		n = redir->neigh;
8e6a9046b66a7d John Hurley 2017-09-25  578  		break;
8e6a9046b66a7d John Hurley 2017-09-25  579  	case NETEVENT_NEIGH_UPDATE:
8e6a9046b66a7d John Hurley 2017-09-25  580  		n = (struct neighbour *)ptr;
8e6a9046b66a7d John Hurley 2017-09-25  581  		break;
8e6a9046b66a7d John Hurley 2017-09-25  582  	default:
8e6a9046b66a7d John Hurley 2017-09-25  583  		return NOTIFY_DONE;
8e6a9046b66a7d John Hurley 2017-09-25  584  	}
8e6a9046b66a7d John Hurley 2017-09-25  585  
6c463a059f626b John Hurley 2019-12-17  586  	if (n->tbl->family == AF_INET6)
6c463a059f626b John Hurley 2019-12-17  587  		ipv6 = true;
6c463a059f626b John Hurley 2019-12-17  588  
9d5447ed44b5dd Louis Peens 2022-05-05  589  	neigh_invalid = !(n->nud_state & NUD_VALID) || n->dead;
9d5447ed44b5dd Louis Peens 2022-05-05  590  
6c463a059f626b John Hurley 2019-12-17  591  	if (ipv6)
6c463a059f626b John Hurley 2019-12-17  592  		flow6.daddr = *(struct in6_addr *)n->primary_key;
6c463a059f626b John Hurley 2019-12-17  593  	else
6c463a059f626b John Hurley 2019-12-17  594  		flow4.daddr = *(__be32 *)n->primary_key;
8e6a9046b66a7d John Hurley 2017-09-25  595  
f3b975778c176b John Hurley 2019-01-15  596  	app_priv = container_of(nb, struct nfp_flower_priv, tun.neigh_nb);
8e6a9046b66a7d John Hurley 2017-09-25  597  	app = app_priv->app;
8e6a9046b66a7d John Hurley 2017-09-25  598  
e8024cb483abb2 John Hurley 2019-08-27  599  	if (!nfp_netdev_is_nfp_repr(n->dev) &&
e8024cb483abb2 John Hurley 2019-08-27  600  	    !nfp_flower_internal_port_can_offload(app, n->dev))
e8024cb483abb2 John Hurley 2019-08-27  601  		return NOTIFY_DONE;
e8024cb483abb2 John Hurley 2019-08-27  602  

:::::: The code at line 567 was first introduced by commit
:::::: 6c463a059f626bc2115b17bee97f014f59dd844a nfp: flower: handle notifiers for ipv6 route changes

:::::: TO: John Hurley <john.hurley@...ronome.com>
:::::: CC: David S. Miller <davem@...emloft.net>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp