netdev - Re: [PATCH net] net: Fix features skip in for_each_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220505183046.19952bf2@kernel.org>
Date:   Thu, 5 May 2022 18:30:46 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Tariq Toukan <tariqt@...dia.com>
Cc:     "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
        Gal Pressman <gal@...dia.com>
Subject: Re: [PATCH net] net: Fix features skip in for_each_netdev_feature()

On Wed, 4 May 2022 11:09:14 +0300 Tariq Toukan wrote:
> The find_next_netdev_feature() macro gets the "remaining length",
> not bit index.
> Passing "bit - 1" for the following iteration is wrong as it skips
> the adjacent bit. Pass "bit" instead.
> 
> Fixes: 3b89ea9c5902 ("net: Fix for_each_netdev_feature on Big endian")
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> Reviewed-by: Gal Pressman <gal@...dia.com>
> ---
>  include/linux/netdev_features.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Hi,
> Please queue to -stable >= v5.0.

You can add the normal Cc: stable tags in networking these days, 
the rules were updated.

But I'll forgo doing that here since your >= 5.0 is incorrect, looks 
like the bad commit got backported to earlier stable branches.
Greg will probably do the right thing based on the Fixes tag, anyway.