netdev - Re: [PATCH net v4 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220505185742.1246d738@kernel.org>
Date:   Thu, 5 May 2022 18:57:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Min Li <min.li.xe@...esas.com>
Cc:     richardcochran@...il.com, lee.jones@...aro.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net v4 1/2] ptp: ptp_clockmatrix: Add PTP_CLK_REQ_EXTTS
 support

On Wed,  4 May 2022 16:50:54 -0400 Min Li wrote:
> Use TOD_READ_SECONDARY for extts to keep TOD_READ_PRIMARY
> for gettime and settime exclusively

Can you fill in more details about what the user visible problem is?
Judging by the fact that you haven't tagged the patch as 
[PATCH net-next] after my previous explanation you do think this 
is a fix. But "Add xyz support" sounds like a feature, not a fix.

> Signed-off-by: Min Li <min.li.xe@...esas.com>
> Acked-by: Richard Cochran <richardcochran@...il.com>

> -	err = char_array_to_timespec(buf, sizeof(buf), ts);
> -
> -	return err;
> +	return char_array_to_timespec(buf, sizeof(buf), ts);

I don't think you were modifying this code, so no need to clean it up
in this commit. It's unrelated to the change you're making now.

>  }

> -	/* Re-enable extts */
> -	if (extts_mask)
> -		idtcm_enable_extts_mask(channel, extts_mask, true);
> +	err = _idtcm_gettime(channel, ts, 10);
>  
>  	return err;
>  }

Here, tho, you are changing the code, and yet you haven't done what 
I asked.