[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5564948.DvuYhMxLoT@eto.sf-tec.de>
Date: Fri, 06 May 2022 12:11:56 +0200
From: Rolf Eike Beer <eike-kernel@...tec.de>
To: linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org,
netdev@...r.kernel.org, Yang Yingliang <yangyingliang@...wei.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org
Subject: Re: [PATCH] ethernet: tulip: fix missing pci_disable_device() on error in tulip_init_one()
Am Freitag, 6. Mai 2022, 11:42:50 CEST schrieb Yang Yingliang:
> Fix the missing pci_disable_device() before return
> from tulip_init_one() in the error handling case.
I would suggest removing the pci_disable_device() from tulip_remove_one()
instead and using pcim_enable_device(), i.e. devres, and let the driver core
handle all these things. Of course more of the used functions could be
converted them, e.g. using devm_alloc_etherdev() and so on.
Eike
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists