netdev - Re: [PATCH net-next v4 1/2] net: phy: broadcom: Add PTP support for some Broadcom PHYs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220506205749.2b89ee57@kernel.org>
Date:   Fri, 6 May 2022 20:57:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     andrew@...n.ch, hkallweit1@...il.com, linux@...linux.org.uk,
        f.fainelli@...il.com, bcm-kernel-feedback-list@...adcom.com,
        netdev@...r.kernel.org, kernel-team@...com, davem@...emloft.net,
        pabeni@...hat.com, edumazet@...gle.com, lasse@...ebeat.app,
        clk@...com
Subject: Re: [PATCH net-next v4 1/2] net: phy: broadcom: Add PTP support for
 some Broadcom PHYs.

On Fri,  6 May 2022 15:42:09 -0700 Jonathan Lemon wrote:
> +struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev)

The prototype for probe and init needs to get added in patch 1:

drivers/net/phy/bcm-phy-ptp.c:803:6: warning: no previous prototype for function 'bcm_ptp_config_init' [-Wmissing-prototypes]
void bcm_ptp_config_init(struct phy_device *phydev)
     ^
drivers/net/phy/bcm-phy-ptp.c:839:25: warning: no previous prototype for function 'bcm_ptp_probe' [-Wmissing-prototypes]
struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev)
                        ^