netdev - Re: [PATCH net] ptp: ocp: Use DIV64_U64_ROUND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7caf6b8e-4329-d9a1-5024-f37cc10edc26@novek.ru>
Date:   Sat, 7 May 2022 01:13:12 +0100
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     Jonathan Lemon <jonathan.lemon@...il.com>, netdev@...r.kernel.org
Cc:     richardcochran@...il.com, kernel-team@...com, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net] ptp: ocp: Use DIV64_U64_ROUND_UP for rounding.

On 06.05.2022 00:40, Jonathan Lemon wrote:
> The initial code used roundup() to round the starting time to
> a multiple of a period.  This generated an error on 32-bit
> systems, so was replaced with DIV_ROUND_UP_ULL().
> 
> However, this truncates to 32-bits on a 64-bit system.  Replace
> with DIV64_U64_ROUND_UP() instead.
> 
> Fixes: 'b325af3cfab9 ("ptp: ocp: Add signal generators and update sysfs nodes")'
> Signed-off-by: Jonathan Lemon <jonathan.lemon@...il.com>

Acked-by: Vadim Fedorenko <vfedorenko@...ek.ru>