netdev - RE: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 May 2022 13:47:39 +0000
From:   <Yuiko.Oshino@...rochip.com>
To:     <andrew@...n.ch>, <kuba@...nel.org>
CC:     <Woojung.Huh@...rochip.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <Ravi.Hegde@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>
Subject: RE: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support.

>-----Original Message-----
>From: Andrew Lunn <andrew@...n.ch>
>Sent: Saturday, May 7, 2022 9:49 AM
>To: Jakub Kicinski <kuba@...nel.org>
>Cc: Yuiko Oshino - C18177 <Yuiko.Oshino@...rochip.com>; Woojung Huh - C21699
><Woojung.Huh@...rochip.com>; davem@...emloft.net; netdev@...r.kernel.org; Ravi
>Hegde - C21689 <Ravi.Hegde@...rochip.com>; UNGLinuxDriver
><UNGLinuxDriver@...rochip.com>
>Subject: Re: [PATCH v4 net-next 2/2] net: phy: smsc: add LAN8742 phy support.
>
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is
>safe
>
>On Fri, May 06, 2022 at 03:45:13PM -0700, Jakub Kicinski wrote:
>> On Thu, 5 May 2022 21:29:13 +0200 Andrew Lunn wrote:
>> > On Thu, May 05, 2022 at 11:12:52AM -0700, Yuiko Oshino wrote:
>> > > The current phy IDs on the available hardware.
>> > >         LAN8742 0x0007C130, 0x0007C131
>> > >
>> > > Signed-off-by: Yuiko Oshino <yuiko.oshino@...rochip.com>
>> >
>> > Reviewed-by: Andrew Lunn <andrew@...n.ch>
>>
>> The comments which I think were requested in the review of v2 and
>> appeared in v3 are now gone, again. Is that okay?
>
>Ah, i had not noticed. Thanks for pointing it out.
>
>Those comments are important, since these mask are odd, somebody is either going to
>ask about them, or try to 'fix' them. Some robot will fall over them, etc.
>
>     Andrew

Hi Andrew and Jakub,
I see that the patches are already applied to net-next?
So should I create a new series with the missing comments only rather than doing v5?
Please let me know.
Thank you.
Yuiko