netdev - Re: [PATCH net-next 3/4] net: make drivers set the TSO limit not the GSO limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPv3WKehhJgOFJRiGSsEb3FeOkm3iBSbSO-N39z8+n=7PWtxHA@mail.gmail.com>
Date:   Mon, 9 May 2022 16:31:28 +0200
From:   Marcin Wojtas <mw@...ihalf.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>, pabeni@...hat.com,
        alexander.duyck@...il.com,
        Stephen Hemminger <stephen@...workplumber.org>,
        j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net,
        chris.snook@...il.com, dchickles@...vell.com, sburla@...vell.com,
        fmanlunas@...vell.com, ajit.khaparde@...adcom.com,
        sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
        qiangqing.zhang@....com, yisen.zhuang@...wei.com,
        salil.mehta@...wei.com, jesse.brandeburg@...el.com,
        anthony.l.nguyen@...el.com,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        gakula@...vell.com, sbhatta@...vell.com, hkelam@...vell.com,
        simon.horman@...igine.com, Heiner Kallweit <hkallweit1@...il.com>,
        ecree.xilinx@...il.com, habetsm.xilinx@...il.com,
        kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, decui@...rosoft.com, woojung.huh@...rochip.com,
        wintera@...ux.ibm.com, roopa@...dia.com, razor@...ckwall.org,
        cai.huoqing@...ux.dev, fei.qin@...igine.com,
        niklas.soderlund@...igine.com, yinjun.zhang@...igine.com,
        marcinguy@...il.com, jesionowskigreg@...il.com, jannh@...gle.com,
        hayeswang@...ltek.com
Subject: Re: [PATCH net-next 3/4] net: make drivers set the TSO limit not the
 GSO limit

HI,

[snip]

> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index f6a54c7f0c69..384f5a16753d 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -5617,7 +5617,7 @@ static int mvneta_probe(struct platform_device *pdev)
>         dev->hw_features |= dev->features;
>         dev->vlan_features |= dev->features;
>         dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
> -       netif_set_gso_max_segs(dev, MVNETA_MAX_TSO_SEGS);
> +       netif_set_tso_max_segs(dev, MVNETA_MAX_TSO_SEGS);
>
>         /* MTU range: 68 - 9676 */
>         dev->min_mtu = ETH_MIN_MTU;
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> index 1a835b48791b..2b7eade373be 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
> @@ -6861,7 +6861,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,
>                 mvpp2_set_hw_csum(port, port->pool_long->id);
>
>         dev->vlan_features |= features;
> -       netif_set_gso_max_segs(dev, MVPP2_MAX_TSO_SEGS);
> +       netif_set_tso_max_segs(dev, MVPP2_MAX_TSO_SEGS);
>         dev->priv_flags |= IFF_UNICAST_FLT;
>

For mvpp2:
Reviewed-by: Marcin Wojtas <mw@...ihalf.com>

Thanks,
Marcin

[snip]