netdev - Re: [PATCH net-next] net: appletalk: remove Apple/Farallon LocalTalk PC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220509103216.180be080@kernel.org>
Date:   Mon, 9 May 2022 10:32:16 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Doug Brown <doug@...morgal.com>
Subject: Re: [PATCH net-next] net: appletalk: remove Apple/Farallon
 LocalTalk PC support

On Mon, 9 May 2022 19:14:42 +0200 Arnd Bergmann wrote:
> On Mon, May 9, 2022 at 5:01 PM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > Looks like all the changes to this driver had been tree-wide
> > refactoring since git era begun. The driver is using virt_to_bus()
> > we should make it use more modern DMA APIs but since it's unlikely
> > to be getting any use these days delete it instead. We can always
> > revert to bring it back.
> >
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>  
> 
> Removing this driver sounds good to me, your description makes sense
> and it gets us closer to completely removing virt_to_bus() in the future.
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>
> 
> I think however, if we remove this driver, we need to discuss removing the
> last remaining localtalk driver (CONFIG_COPS) and possibly the localtalk
> bits in net/appletalk along with it.
> 
> Doug Brown suggested removing COPS last year for entirely different
> reasons[1] but never got a reply. I suppose that is a sign that nobody
> cared about the driver enough, but we should remove it. He also
> mentioned working on a new localtalk driver, though I don't think he
> posted that one yet.
> 
>        Arnd
> 
> [1] https://lore.kernel.org/netdev/6c62d7d5-5171-98a3-5287-ecb1df20f574@schmorgal.com/

Very interesting, thanks!

Removing COPS and appletalk makes perfect sense to me (minus what Doug
has plans to use, obviously).

I'm taking notes for "next steps" while trying to strategically cast 
a narrow net, hitting VIRT_TO_BUS only now.