netdev - Re: [PATCH net] netfilter: nf_flow_table: fix teardown flow timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220509085149.ixdy3fbombutdpd7@SvensMacbookPro.hq.voleatech.com>
Date:   Mon, 9 May 2022 10:51:49 +0200
From:   Sven Auhagen <sven.auhagen@...eatech.de>
To:     Oz Shlomo <ozsh@...dia.com>
Cc:     Pablo Neira Ayuso <pablo@...filter.org>,
        Felix Fietkau <nbd@....name>, netdev@...r.kernel.org,
        netfilter-devel@...r.kernel.org, Florian Westphal <fw@...len.de>,
        Paul Blakey <paulb@...dia.com>
Subject: Re: [PATCH net] netfilter: nf_flow_table: fix teardown flow timeout

Hi Oz,

thank you, this patch fixes the race between ct gc and flowtable teardown.
There is another big problem though in the code currently and I will send a patch
in a minute.

The flowtable teardown code always forces the ct state back to established
and adds the established timeout to it even if it is in CLOSE or FIN WAIT
which ultimately leads to a huge number of dead states in established state.

I will CC you on the patch, where I also stumbled upon your issue.

Best
Sven

On Mon, May 09, 2022 at 10:29:16AM +0300, Oz Shlomo wrote:
> Connections leaving the established state (due to RST / FIN TCP packets)
> set the flow table teardown flag. The packet path continues to set lower
> timeout value as per the new TCP state but the offload flag remains set.
> Hence, the conntrack garbage collector may race to undo the timeout
> adjustment of the packet path, leaving the conntrack entry in place with
> the internal offload timeout (one day).
> 
> Return the connection's ownership to conntrack upon teardown by clearing
> the offload flag and fixing the established timeout value. The flow table
> GC thread will asynchonrnously free the flow table and hardware offload
> entries.
> 
> Fixes: 1e5b2471bcc4 ("netfilter: nf_flow_table: teardown flow timeout race")
> Signed-off-by: Oz Shlomo <ozsh@...dia.com>
> Reviewed-by: Paul Blakey <paulb@...dia.com>
> ---
>  net/netfilter/nf_flow_table_core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/netfilter/nf_flow_table_core.c b/net/netfilter/nf_flow_table_core.c
> index 3db256da919b..ef080dbd4fd0 100644
> --- a/net/netfilter/nf_flow_table_core.c
> +++ b/net/netfilter/nf_flow_table_core.c
> @@ -375,6 +375,9 @@ void flow_offload_teardown(struct flow_offload *flow)
>  	set_bit(NF_FLOW_TEARDOWN, &flow->flags);
>  
>  	flow_offload_fixup_ct_state(flow->ct);
> +	flow_offload_fixup_ct_timeout(flow->ct);
> +
> +	clear_bit(IPS_OFFLOAD_BIT, &flow->ct->status);
>  }
>  EXPORT_SYMBOL_GPL(flow_offload_teardown);
>  
> -- 
> 1.8.3.1
>