netdev - Re: [PATCH net v2] net: macsec: retrieve the XPN attributes before offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 May 2022 08:01:07 +0000
From:   Carlos Fernandez <carlos.fernandez@...hnica-engineering.de>
To:     Paolo Abeni <pabeni@...hat.com>,
        Carlos Fernandez <carlos.escuin@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net v2] net: macsec: retrieve the XPN attributes before
 offloading

Thanks Paolo,

I'll redo the patch and send it again.
About the changes between the previous patch, there're only changes on the description and format of the patch, but none on the code side, maybe referencing them is irrelevant.

________________________________________
From: Paolo Abeni <pabeni@...hat.com>
Sent: Tuesday, May 10, 2022 9:09 AM
To: Carlos Fernandez; Carlos Fernandez; davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: macsec: retrieve the XPN attributes before offloading

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

Hello,

On Fri, 2022-05-06 at 12:55 +0200, Carlos Fernandez wrote:
> When MACsec offloading is used with XPN, before mdo_add_rxsa
> and mdo_add_txsa functions are called, the key salt is not
> copied to the macsec context struct. Offloaded phys will need
> this data when performing offloading.
>
> Fix by copying salt and id to context struct before calling the
> offloading functions.
>
> Fixes: 48ef50fa866a ("macsec: Netlink support of XPN cipher suites")
>
> Signed-off-by: Carlos Fernandez <carlos.fernandez@...hnica-engineering.de>

I'm sorry for nit-picking, but you must avoid empty lines between the
the 'Fixes' and the 'Signed-off-by' tags (or any other tag).

Additionnaly you should include a summary of the changes WRT the
previous patch version, see e.g. commit cec16052d5a7.

The patch contents looks good, but it's better if you address the
above, thanks!

Paolo