netdev - Re: [PATCH net-next v8 02/14] net: skb: introduce skb_data_area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 May 2022 13:01:06 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Martinez, Ricardo" <ricardo.martinez@...ux.intel.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Sergey Ryazanov <ryazanov.s.a@...il.com>,
        netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        David Miller <davem@...emloft.net>,
        Johannes Berg <johannes@...solutions.net>,
        Loic Poulain <loic.poulain@...aro.org>,
        M Chetan Kumar <m.chetan.kumar@...el.com>,
        "Devegowda, Chandrashekar" <chandrashekar.devegowda@...el.com>,
        Intel Corporation <linuxwwan@...el.com>,
        chiranjeevi.rapolu@...ux.intel.com,
        Haijun Liu ( 刘海军) 
        <haijun.liu@...iatek.com>,
        "Hanania, Amir" <amir.hanania@...el.com>,
        "Sharma, Dinesh" <dinesh.sharma@...el.com>,
        "Lee, Eliot" <eliot.lee@...el.com>,
        "Jarvinen, Ilpo Johannes" <ilpo.johannes.jarvinen@...el.com>,
        "Veleta, Moises" <moises.veleta@...el.com>,
        "Bossart, Pierre-louis" <pierre-louis.bossart@...el.com>,
        "Sethuraman, Muralidharan" <muralidharan.sethuraman@...el.com>,
        "Mishra, Soumya Prakash" <Soumya.Prakash.Mishra@...el.com>,
        "Kancharla, Sreehari" <sreehari.kancharla@...el.com>,
        "Sahu, Madhusmita" <madhusmita.sahu@...el.com>
Subject: Re: [PATCH net-next v8 02/14] net: skb: introduce
 skb_data_area_size()

On Mon, May 09, 2022 at 02:37:26PM -0700, Martinez, Ricardo wrote:
> On 5/9/2022 12:50 PM, Jakub Kicinski wrote:
> > On Mon, 9 May 2022 21:34:58 +0300 Sergey Ryazanov wrote:

...

> > We have two cases:
> >   - for Tx - drivers should use skb_headlen();
> >   - for Rx - I presume we are either dealing with fresh or correctly
> >     reset skbs, so we can use skb_tailroom().
> Thanks for the information, looks like indeed we can avoid the helper in
> t7xx driver by following those guidelines.

I think this can be done as a follow up patch.

-- 
With Best Regards,
Andy Shevchenko