netdev - Re: [PATCH 1/1] batman-adv: Don't skb_split skbuffs with frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165214561288.15844.2929287601845577779.git-patchwork-notify@kernel.org>
Date:   Tue, 10 May 2022 01:20:12 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Simon Wunderlich <sw@...onwunderlich.de>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        b.a.t.m.a.n@...ts.open-mesh.org, sven@...fation.org,
        felix@...chele.ca
Subject: Re: [PATCH 1/1] batman-adv: Don't skb_split skbuffs with frag_list

Hello:

This patch was applied to netdev/net.git (master)
by Simon Wunderlich <sw@...onwunderlich.de>:

On Sun,  8 May 2022 15:21:10 +0200 you wrote:
> From: Sven Eckelmann <sven@...fation.org>
> 
> The receiving interface might have used GRO to receive more fragments than
> MAX_SKB_FRAGS fragments. In this case, these will not be stored in
> skb_shinfo(skb)->frags but merged into the frag list.
> 
> batman-adv relies on the function skb_split to split packets up into
> multiple smaller packets which are not larger than the MTU on the outgoing
> interface. But this function cannot handle frag_list entries and is only
> operating on skb_shinfo(skb)->frags. If it is still trying to split such an
> skb and xmit'ing it on an interface without support for NETIF_F_FRAGLIST,
> then validate_xmit_skb() will try to linearize it. But this fails due to
> inconsistent information. And __pskb_pull_tail will trigger a BUG_ON after
> skb_copy_bits() returns an error.
> 
> [...]

Here is the summary with links:
  - [1/1] batman-adv: Don't skb_split skbuffs with frag_list
    https://git.kernel.org/netdev/net/c/a063f2fba3fa

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html