netdev - Re: [PATCH net-next v1] mlxbf_gige: remove driver-managed interrupt counts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220510152431.0d7673bb@kernel.org>
Date:   Tue, 10 May 2022 15:24:31 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Thompson <davthompson@...dia.com>
Cc:     <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
        <netdev@...r.kernel.org>, <limings@...dia.com>,
        <cai.huoqing@...ux.dev>, Asmaa Mnebhi <asmaa@...dia.com>
Subject: Re: [PATCH net-next v1] mlxbf_gige: remove driver-managed interrupt
 counts

On Mon, 9 May 2022 11:24:26 -0400 David Thompson wrote:
> The driver currently has three interrupt counters,
> which are incremented every time each interrupt handler
> executes.  These driver-managed counters are not
> necessary as the kernel already has logic that manages
> interrupt counts and exposes them via /proc/interrupts.
> This patch removes the driver-managed counters, and thus
> removes them from "ethtool -S" output as well.

The last part of the last sentence is not true, or at
least I don't see the patch removing any ethtool -S keys.
I think we requested you removed them from ethtool -S 
during initial upstream review.