netdev - Re: [PATCH v5 net-next 13/13] mlx5: support BIG TCP packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iLQvZFZzonh5SAyWkinujO4sc3bSjrQMKQxGabZyGLnLw@mail.gmail.com>
Date:   Mon, 9 May 2022 19:00:28 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        Kees Cook <keescook@...omium.org>,
        "David S . Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        netdev <netdev@...r.kernel.org>,
        Alexander Duyck <alexanderduyck@...com>,
        Coco Li <lixiaoyan@...gle.com>,
        Tariq Toukan <tariqt@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Leon Romanovsky <leon@...nel.org>
Subject: Re: [PATCH v5 net-next 13/13] mlx5: support BIG TCP packets

On Mon, May 9, 2022 at 6:38 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Mon,  9 May 2022 15:21:49 -0700 Eric Dumazet wrote:
> > From: Coco Li <lixiaoyan@...gle.com>
> >
> > mlx5 supports LSOv2.
> >
> > IPv6 gro/tcp stacks insert a temporary Hop-by-Hop header
> > with JUMBO TLV for big packets.
> >
> > We need to ignore/skip this HBH header when populating TX descriptor.
> >
> > Note that ipv6_has_hopopt_jumbo() only recognizes very specific packet
> > layout, thus mlx5e_sq_xmit_wqe() is taking care of this layout only.
> >
> > v2: clear hopbyhop in mlx5e_tx_get_gso_ihs()
> > v4: fix compile error for CONFIG_MLX5_CORE_IPOIB=y
> >
> > Signed-off-by: Coco Li <lixiaoyan@...gle.com>
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > Reviewed-by: Tariq Toukan <tariqt@...dia.com>
> > Cc: Saeed Mahameed <saeedm@...dia.com>
> > Cc: Leon Romanovsky <leon@...nel.org>
>
> So we're leaving the warning for Kees to deal with?

I think so. I do not see an easy way to escape this, unless perhaps add some
extra obfuscation, so that gcc can not determine the memcpy() third
argument at compile time.

Alternative is to remove mlx5 patch from the upstream series.

>
> Kees is there some form of "I know what I'm doing" cast
> that you could sneak us under the table?