netdev - Re: [PATCH v5 net-next 02/13] net: allow gso_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202205101045.zaceqBiC-lkp@intel.com>
Date:   Tue, 10 May 2022 11:08:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        netdev <netdev@...r.kernel.org>,
        Alexander Duyck <alexanderduyck@...com>,
        Coco Li <lixiaoyan@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH v5 net-next 02/13] net: allow gso_max_size to exceed 65536

Hi Eric,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/tcp-BIG-TCP-implementation/20220510-062530
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9c095bd0d4c451d31d0fd1131cc09d3b60de815d
config: arm-spear3xx_defconfig (https://download.01.org/0day-ci/archive/20220510/202205101045.zaceqBiC-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 3abb68a626160e019c30a4860e569d7bc75e486a)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/8f9b47ee99f57d1747010d002315092bfa17ed50
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Eric-Dumazet/tcp-BIG-TCP-implementation/20220510-062530
        git checkout 8f9b47ee99f57d1747010d002315092bfa17ed50
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> net/core/sock.c:2317:51: error: no member named 'skc_v6_rcv_saddr' in 'struct sock_common'; did you mean 'skc_rcv_saddr'?
                                !sk_is_tcp(sk) || ipv6_addr_v4mapped(&sk->sk_v6_rcv_saddr)))
                                                                          ^
   include/net/sock.h:389:37: note: expanded from macro 'sk_v6_rcv_saddr'
   #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
                                       ^
   include/net/sock.h:171:11: note: 'skc_rcv_saddr' declared here
                           __be32  skc_rcv_saddr;
                                   ^
   1 error generated.


vim +2317 net/core/sock.c

  2295	
  2296	void sk_setup_caps(struct sock *sk, struct dst_entry *dst)
  2297	{
  2298		u32 max_segs = 1;
  2299	
  2300		sk_dst_set(sk, dst);
  2301		sk->sk_route_caps = dst->dev->features;
  2302		if (sk_is_tcp(sk))
  2303			sk->sk_route_caps |= NETIF_F_GSO;
  2304		if (sk->sk_route_caps & NETIF_F_GSO)
  2305			sk->sk_route_caps |= NETIF_F_GSO_SOFTWARE;
  2306		if (unlikely(sk->sk_gso_disabled))
  2307			sk->sk_route_caps &= ~NETIF_F_GSO_MASK;
  2308		if (sk_can_gso(sk)) {
  2309			if (dst->header_len && !xfrm_dst_offload_ok(dst)) {
  2310				sk->sk_route_caps &= ~NETIF_F_GSO_MASK;
  2311			} else {
  2312				sk->sk_route_caps |= NETIF_F_SG | NETIF_F_HW_CSUM;
  2313				/* pairs with the WRITE_ONCE() in netif_set_gso_max_size() */
  2314				sk->sk_gso_max_size = READ_ONCE(dst->dev->gso_max_size);
  2315				if (sk->sk_gso_max_size > GSO_LEGACY_MAX_SIZE &&
  2316				    (!IS_ENABLED(CONFIG_IPV6) || sk->sk_family != AF_INET6 ||
> 2317				     !sk_is_tcp(sk) || ipv6_addr_v4mapped(&sk->sk_v6_rcv_saddr)))
  2318					sk->sk_gso_max_size = GSO_LEGACY_MAX_SIZE;
  2319				sk->sk_gso_max_size -= (MAX_TCP_HEADER + 1);
  2320				/* pairs with the WRITE_ONCE() in netif_set_gso_max_segs() */
  2321				max_segs = max_t(u32, READ_ONCE(dst->dev->gso_max_segs), 1);
  2322			}
  2323		}
  2324		sk->sk_gso_max_segs = max_segs;
  2325	}
  2326	EXPORT_SYMBOL_GPL(sk_setup_caps);
  2327	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp