netdev - [PATCH net 0/2] sfc: fix some efx_separate_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 May 2022 14:59:39 +0200
From:   Íñigo Huguet <ihuguet@...hat.com>
To:     ecree.xilinx@...il.com, habetsm.xilinx@...il.com,
        amaftei@...arflare.com
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        Íñigo Huguet <ihuguet@...hat.com>
Subject: [PATCH net 0/2] sfc: fix some efx_separate_tx_channels errors

These patches fix some errors that happens at NIC's probe when using the
modparam efx_separate_tx_channels. However, there are still some other
errors that prevent from using the NIC with that modparam and I haven't
been able to find the cause (see the 2nd patch).

Anyway, my opinion is that this parameter should be better removed: it
has been completely broken for years and no users have complained, so I
don't think it's used anywhere. Discussed this with Edward and he was of
the opinion that removing a modparam is problematic because it breaks
compatibility, but I still think it should because of the reason above.

Íñigo Huguet (2):
  sfc: fix wrong tx channel offset with efx_separate_tx_channels
  sfc: do not initialize non existing queues with
    efx_separate_tx_channels

 drivers/net/ethernet/sfc/efx_channels.c | 39 ++++++++++++-------------
 1 file changed, 18 insertions(+), 21 deletions(-)

-- 
2.34.1