[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220511132421.7o5a3po32l3w2wcr@pengutronix.de>
Date: Wed, 11 May 2022 15:24:21 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Oliver Hartkopp <socketcan@...tkopp.net>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>,
Wolfgang Grandegger <wg@...ndegger.com>,
Devid Antonio Filoni <devid.filoni@...uetechnologies.com>,
kernel@...gutronix.de, linux-can@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
David Jander <david@...tonic.nl>
Subject: Re: [PATCH 1/1] can: skb: add and set local_origin flag
On 11.05.2022 14:38:32, Oliver Hartkopp wrote:
> IMO this patch does not work as intended.
>
> You probably need to revisit every place where can_skb_reserve() is used,
> e.g. in raw_sendmsg().
And the loopback for devices that don't support IFF_ECHO:
| https://elixir.bootlin.com/linux/latest/source/net/can/af_can.c#L257
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists