netdev - Re: [PATCH] igb_ethtool: fix efficiency issues in igb_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <AD31AFC0-2621-4671-986A-8BCE2AA9F514@gmail.com>
Date:   Wed, 11 May 2022 14:26:45 +0800
From:   lixue liang <lixue.liang5086@...il.com>
To:     Jesse Brandeburg <jesse.brandeburg@...el.com>
Cc:     anthony.l.nguyen@...el.com, Jakub Kicinski <kuba@...nel.org>,
        intel-wired-lan@...ts.osuosl.org, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] igb_ethtool: fix efficiency issues in igb_set_eeprom

Thank you very much for replying to my question and for suggesting corrections.

Since the interface (igb_set_eeprom) for arbitrarily modifying the mac address is provided, 
it is equivalent to providing a way to modify the mac address arbitrarily and cause the igb 
driver to fail to load. Therefore, a way to restore a valid mac address should also be reserved, 
so as to prevent most users from being helpless in the case of an invalid mac address.

Except by using tools to flash the firmware or modify the igb driver to continue loading under 
an invalid mac address, however most users do not have this ability. In the case of invalidity, 
the invalid mac address must be changed to a legal address, so it is always better to use a 
valid mac address to continue pretending to be a network card driver when the mac address is invalid,
 which is always better than not being able to load the driver, such as the microchip network card (lan743x) driver .

I think it is worthwhile to replace the invalid mac address with a random valid mac address to 
complete the igb driver loading. In response to the above problem, I will provide a patch on igb_main.c again..

Thank you for taking the time.

> 2022年5月11日 03:43，Jesse Brandeburg <jesse.brandeburg@...el.com> 写道：
> 
> Please include netdev mailing list when mailing the maintainers of netdev.