netdev - RE: [PATCH net-next] net: enetc: kill PHY-less mode for PFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM9PR04MB8397286D5D10B0432D1457F296C89@AM9PR04MB8397.eurprd04.prod.outlook.com>
Date:   Wed, 11 May 2022 07:28:36 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Michael Walle <michael@...le.cc>
Subject: RE: [PATCH net-next] net: enetc: kill PHY-less mode for PFs

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@....com>
> Sent: Tuesday, May 10, 2022 7:40 PM
[...]
> Subject: [PATCH net-next] net: enetc: kill PHY-less mode for PFs
> 
[...]
> +	err = of_get_phy_mode(node, &pf->if_mode);
> +	if (err) {
> +		dev_err(&pdev->dev, "Failed to read PHY mode\n");
> +		goto err_phy_mode;
>  	}
> 
> +	err = enetc_mdiobus_create(pf, node);
> +	if (err)
> +		goto err_mdiobus_create;
> +
> +	err = enetc_phylink_create(priv, node);
> +	if (err)
> +		goto err_phylink_create;
> +
>  	err = register_netdev(ndev);
>  	if (err)
>  		goto err_reg_netdev;
> @@ -1296,6 +1299,7 @@ static int enetc_pf_probe(struct pci_dev *pdev,
>  err_mdiobus_create:
>  	enetc_free_msix(priv);
>  err_config_si:
> +err_phy_mode:

err_phy_mode should bail out at enetc_free_msix()

>  err_alloc_msix:
>  	enetc_free_si_resources(priv);
>  err_alloc_si_res:
> --
> 2.25.1