netdev - Re: [PATCH v2 net-next] net: enetc: kill PHY-less mode for PFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165234781183.20356.8084203949340679535.git-patchwork-notify@kernel.org>
Date:   Thu, 12 May 2022 09:30:11 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
        pabeni@...hat.com, edumazet@...gle.com, claudiu.manoil@....com,
        michael@...le.cc
Subject: Re: [PATCH v2 net-next] net: enetc: kill PHY-less mode for PFs

Hello:

This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@...hat.com>:

On Wed, 11 May 2022 12:42:00 +0300 you wrote:
> Right now, a PHY-less port (no phy-mode, no fixed-link, no phy-handle)
> doesn't register with phylink, but calls netif_carrier_on() from
> enetc_start().
> 
> This makes sense for a VF, but for a PF, this is braindead, because we
> never call enetc_mac_enable() so the MAC is left inoperational.
> Furthermore, commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and
> PCS_LYNX") put the nail in the coffin because it removed the initial
> netif_carrier_off() call done right after register_netdev().
> 
> [...]

Here is the summary with links:
  - [v2,net-next] net: enetc: kill PHY-less mode for PFs
    https://git.kernel.org/netdev/net-next/c/0f84d403b8e5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html