lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 12 May 2022 09:30:11 +0000
To:     Vladimir Oltean <>
Subject: Re: [PATCH v2 net-next] net: enetc: kill PHY-less mode for PFs


This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <>:

On Wed, 11 May 2022 12:42:00 +0300 you wrote:
> Right now, a PHY-less port (no phy-mode, no fixed-link, no phy-handle)
> doesn't register with phylink, but calls netif_carrier_on() from
> enetc_start().
> This makes sense for a VF, but for a PF, this is braindead, because we
> never call enetc_mac_enable() so the MAC is left inoperational.
> Furthermore, commit 71b77a7a27a3 ("enetc: Migrate to PHYLINK and
> PCS_LYNX") put the nail in the coffin because it removed the initial
> netif_carrier_off() call done right after register_netdev().
> [...]

Here is the summary with links:
  - [v2,net-next] net: enetc: kill PHY-less mode for PFs

You are awesome, thank you!
Deet-doot-dot, I am a bot.

Powered by blists - more mailing lists