netdev - Re: [PATCH net-next 01/14] net: txgbe: Add build support for txgbe ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 May 2022 08:38:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Jiawen Wu <jiawenwu@...stnetic.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Jiawen Wu <jiawenwu@...stnetic.com>
Subject: Re: [PATCH net-next 01/14] net: txgbe: Add build support for txgbe
 ethernet driver

Hi Jiawen,

I love your patch! Perhaps something to improve:

[auto build test WARNING on horms-ipvs/master]
[cannot apply to net-next/master net/master linus/master v5.18-rc6 next-20220511]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Jiawen-Wu/Wangxun-10-Gigabit-Ethernet-Driver/20220511-113032
base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs.git master
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20220512/202205120837.ym9aTQJ0-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/63bf477b5f111995b0ea1fcf839b7e6b0c06ca55
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Jiawen-Wu/Wangxun-10-Gigabit-Ethernet-Driver/20220511-113032
        git checkout 63bf477b5f111995b0ea1fcf839b7e6b0c06ca55
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/wangxun/txgbe/txgbe_main.c:47:6: warning: no previous prototype for 'txgbe_service_event_schedule' [-Wmissing-prototypes]
      47 | void txgbe_service_event_schedule(struct txgbe_adapter *adapter)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/ethernet/wangxun/txgbe/txgbe_main.c: In function 'txgbe_probe':
   drivers/net/ethernet/wangxun/txgbe/txgbe_main.c:148:18: warning: variable 'pci_using_dac' set but not used [-Wunused-but-set-variable]
     148 |         int err, pci_using_dac;
         |                  ^~~~~~~~~~~~~


vim +/txgbe_service_event_schedule +47 drivers/net/ethernet/wangxun/txgbe/txgbe_main.c

    46	
  > 47	void txgbe_service_event_schedule(struct txgbe_adapter *adapter)
    48	{
    49		if (!test_bit(__TXGBE_DOWN, &adapter->state) &&
    50		    !test_bit(__TXGBE_REMOVING, &adapter->state) &&
    51		    !test_and_set_bit(__TXGBE_SERVICE_SCHED, &adapter->state))
    52			queue_work(txgbe_wq, &adapter->service_task);
    53	}
    54	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp