netdev - Re: [PATCH net-next v7 0/2] axienet NAPI improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 May 2022 23:00:02 +0000
From:   Robert Hancock <robert.hancock@...ian.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "pabeni@...hat.com" <pabeni@...hat.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "radhey.shyam.pandey@...inx.com" <radhey.shyam.pandey@...inx.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next v7 0/2] axienet NAPI improvements

On Thu, 2022-05-12 at 11:18 -0600, Robert Hancock wrote:
> Changes to support TX NAPI in the axienet driver, as well as fixing
> a potential concurrency issue in the TX ring pointer handling.
> 
> Supersedes v5 of the individual patch
> "net: axienet: Use NAPI for TX completion path".
> 
> Changed since v6: Use READ_ONCE where the value actually does need to
> be read once, in axienet_check_tx_bd_space, not in axienet_start_xmit
> where it doesn't.
> 
> Changed since v5: Replaced spinlock with fixes to the way the TX ring
> tail pointer is updated, and broke those changes into a separate patch.
> 
> Changed since v4: Added locking to protect TX ring tail pointer against
> concurrent access by TX transmit and TX poll paths.
> 
> Changed since v3: Fixed references to renamed function in comments
> 
> Changed since v2: Use separate TX and RX NAPI poll handlers to keep
> completion handling on same CPU as TX/RX IRQ. Added hard/soft IRQ
> benchmark information to commit message.
> 
> Changed since v1: Added benchmark information to commit message, no
> code changes.
> 
> Robert Hancock (2):
>   net: axienet: Be more careful about updating tx_bd_tail
>   net: axienet: Use NAPI for TX completion path
> 
>  drivers/net/ethernet/xilinx/xilinx_axienet.h  |  54 +++---
>  .../net/ethernet/xilinx/xilinx_axienet_main.c | 168 ++++++++++--------
>  2 files changed, 126 insertions(+), 96 deletions(-)
> 

Looking at Patchwork and Lore, seems like this cover letter may not have made
it to the list, though the two patches did? Can resend if it doesn't eventually
show up..

-- 
Robert Hancock
Senior Hardware Designer, Calian Advanced Technologies
www.calian.com