lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 May 2022 09:02:13 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Maxim Mikityanskiy <maximmi@...dia.com> Cc: "David S. Miller" <davem@...emloft.net>, Daniel Borkmann <daniel@...earbox.net>, Paolo Abeni <pabeni@...hat.com>, Boris Pismenny <borisp@...dia.com>, Tariq Toukan <tariqt@...dia.com>, Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>, netdev@...r.kernel.org Subject: Re: [PATCH net-next v2] tls: Add opt-in zerocopy mode of sendfile() On Fri, 13 May 2022 10:57:06 +0300 Maxim Mikityanskiy wrote: > > What about the reporting via sock diag? Am I misremembering something? > > I recall we discussed that "zerocopy is active" can be restored as > "hardware offload && setsockopt flag requested", and I saw that > tls_get_info exposes the hardware offload state for the socket, so I > thought the existing information in sock_diag was enough. > > If you think, though, that it will be better to have an explicit > indication of the zerocopy flag to sock_diag, I can add it, it's not a > problem. Yeah, my thinking is that if a user reports problems to me I'd like to be able to log in to the box and see what they have configured on the socket. ss is quick and easy to type. I'm not aware of tooling that'd grab descriptors for sockets and do getsockopt() (even tho technically it is doable), are there any? I'm not feeling strong about sock_diag specifically being the way but for such a potentially correctness- -impacting optimization we should give admins an easy way to interrogate if it's enabled or not. > Does the rest of the patch look good to you? Yup!
Powered by blists - more mailing lists