lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 May 2022 10:41:08 +0800 From: Menglong Dong <menglong8.dong@...il.com> To: Jakub Kicinski <kuba@...nel.org> Cc: Neil Horman <nhorman@...driver.com>, David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, David Ahern <dsahern@...nel.org>, Menglong Dong <imagedong@...cent.com>, Martin Lau <kafai@...com>, Talal Ahmad <talalahmad@...gle.com>, Kees Cook <keescook@...omium.org>, asml.silence@...il.com, Willem de Bruijn <willemb@...gle.com>, vasily.averin@...ux.dev, Ilias Apalodimas <ilias.apalodimas@...aro.org>, Luiz Augusto von Dentz <luiz.von.dentz@...el.com>, LKML <linux-kernel@...r.kernel.org>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH net-next v2 2/4] net: skb: check the boundrary of drop reason in kfree_skb_reason() On Fri, May 13, 2022 at 12:16 AM Jakub Kicinski <kuba@...nel.org> wrote: > > On Thu, 12 May 2022 20:33:11 +0800 menglong8.dong@...il.com wrote: > > + if (unlikely(reason <= 0 || reason >= SKB_DROP_REASON_MAX)) { > > + DEBUG_NET_WARN_ON_ONCE(1); > > + reason = SKB_DROP_REASON_NOT_SPECIFIED; > > + } > > With drop_monitor fixes sending an invalid reason to the tracepoint > should be a minor bug, right? > > Can we just have a: > > DEBUG_NET_WARN_ON_ONCE(reason <= 0 || reason >= SKB_DROP_REASON_MAX); > > and avoid having this branch on non-debug builds? Yeah, it seems this way is more logical. I'll change it in the V3.
Powered by blists - more mailing lists