netdev - RE: [PATCH] net: usb: r8152: Set default WOL options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 May 2022 03:31:33 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Kyle Pelton <kyle.d.pelton@...ux.intel.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "aaron.ma@...onical.com" <aaron.ma@...onical.com>
CC:     nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [PATCH] net: usb: r8152: Set default WOL options

Kyle Pelton <kyle.d.pelton@...ux.intel.com>
> Sent: Friday, May 13, 2022 5:50 AM
[...]
>  #define WAKE_ANY (WAKE_PHY | WAKE_MAGIC | WAKE_UCAST |
> WAKE_BCAST | WAKE_MCAST)
> +#define WAKE_DEFAULT (WAKE_PHY << 5)

I think the (WAKE_PHY << 5) is equal to WAKE_MAGIC.

>  static u32 __rtl_get_wol(struct r8152 *tp)
>  {
> @@ -9717,10 +9718,12 @@ static int rtl8152_probe(struct usb_interface *intf,
> 
>  	intf->needs_remote_wakeup = 1;
> 
> -	if (!rtl_can_wakeup(tp))
> +	if (!rtl_can_wakeup(tp)) {
>  		__rtl_set_wol(tp, 0);
> -	else
> +	} else {
> +		__rtl_set_wol(tp, WAKE_DEFAULT);
>  		tp->saved_wolopts = __rtl_get_wol(tp);

I think it is better to set tp->saved_wolopts = WAKE_MAGIC. Besides,
add rtl_runtime_suspend_enable(tp, false) in r8152b_init() as same
as r8153_init(), r8153b_init(), and so on. You don't need
__rtl_set_wol() here.

> +	}
> 
>  	tp->rtl_ops.init(tp);
>  #if IS_BUILTIN(CONFIG_USB_RTL8152)


Best Regards,
Hayes