netdev - Re: [RFC] netfilter: nf_tables: ignore errors on flowtable device hw offload setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yn4NnwAkoVryQtCK@salvia>
Date:   Fri, 13 May 2022 09:49:51 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Felix Fietkau <nbd@....name>
Cc:     netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        Jo-Philipp Wich <jo@...n.io>
Subject: Re: [RFC] netfilter: nf_tables: ignore errors on flowtable device hw
 offload setup

Hi,

On Tue, May 10, 2022 at 10:27:39PM +0200, Felix Fietkau wrote:
> In many cases, it's not easily possible for user space to know, which
> devices properly support hardware offload.

Then, it is a matter of extending the netlink interface to expose this
feature? Probably add a FLOW_BLOCK_PROBE or similar which allow to
consult if this feature is available?

> Even if a device supports hardware flow offload, it is not
> guaranteed that it will actually be able to handle the flows for
> which hardware offload is requested.

When might this happen?

> Ignoring errors on the FLOW_BLOCK_BIND makes it a lot easier to set up
> configurations that use hardware offload where possible and gracefully
> fall back to software offload for everything else.

I understand this might be useful from userspace perspective, because
forcing the user to re-try is silly.

However, on the other hand, the user should have some way to know from
the control plane that the feature (hardware offload) that they
request is not available for their setup.

> Cc: Jo-Philipp Wich <jo@...n.io>
> Signed-off-by: Felix Fietkau <nbd@....name>
> ---
>  net/netfilter/nf_tables_api.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
> index 16c3a39689f4..9d4528f0aa12 100644
> --- a/net/netfilter/nf_tables_api.c
> +++ b/net/netfilter/nf_tables_api.c
> @@ -7323,11 +7323,9 @@ static int nft_register_flowtable_net_hooks(struct net *net,
>  			}
>  		}
>  
> -		err = flowtable->data.type->setup(&flowtable->data,
> -						  hook->ops.dev,
> -						  FLOW_BLOCK_BIND);
> -		if (err < 0)
> -			goto err_unregister_net_hooks;
> +		flowtable->data.type->setup(&flowtable->data,
> +					    hook->ops.dev,
> +					    FLOW_BLOCK_BIND);
>  
>  		err = nf_register_net_hook(net, &hook->ops);
>  		if (err < 0) {
> -- 
> 2.36.1
>